Should a person feel pleased, or have a virtuous vision after offering Istikhara (guidance prayer) in order to do what he/she had offered it for?
The result of the Istikhaarah is not necessarily that a person sees something (in his dream), or feels pleased, but the most important result of the Istikhaarah is whether a person is enabled to do a given matter or not.
If someone regularly fasts the six days of Shawwal, are they obligated to fast them every year?
A person is not obligated to fast the six days of Shawwal every year, even if they have made it a habit. However, someone who regularly performs a good deed should not abandon it as long as they are able.
Should one who doesn`t perform prayer out of laziness make it up later, and how should he/she do so?
All perfect praise be to Allah,The Lord of The Worlds He/she is obliged to make up missed prayers by offering with each obligatory prayer another one, and if he/she offers two, then it is better. And Allah Knows Best.
Is it valid to have Suhoor before sleeping, even if it is before midnight?
Suhoor refers to the pre-dawn meal eaten after midnight to help a Muslim endure fasting. The closer it is to Fajr, the better.
The Prophet ﷺ said: "My Ummah will remain upon goodness as long as they hasten to break the fast and delay Suhoor." [Narrated by Ahmad]
This is because delaying Suhoor makes it more effective in providing strength for worship. However, if there is a risk of Fajr entering while eating, one should refrain from Suhoor out of caution.
The Prophet ﷺ said: "Leave what makes you doubt for what does not make you doubt." [Narrated by Al-Tirmidhi]