What is the ruling on someone who doesn`t perform prayer?

All perfect praise be to Allah,The Lord of The Worlds                                                                                                                                                                    Not performing prayer is a major sin, and one who doesn`t pray out of laziness is considered an oft-sinner ;whereas, the one who denies that it is mandatory is considered a disbeliever. And Allah Knows Best.

Is Zakah (obligatory charity) due on the money saved for marriage?

Zakah is due on the money saved for marriage if it reached the Nissab (minimum amount liable for Zakah), and a whole lunar year had lapsed over possessing it.

Is it permissible to repeat the Istikhara (seeking guidance) prayer, and is it a condition that one should sleep after offering it?

All perfect praise be to Allah,The Lord of The Worlds                                                                                                                                                            Istikhara is offered once, but it is permissible to repeat it, and sleeping after offering it is not a condition for its validity. And Allah Knows Best.

Is it permissible for the man to go out wearing shorts?

All Perfect Praise is due to Allah, The Lord of The Worlds

It is permissible so long as his Awrah (private part), which is between his navel and knee, is covered. However, the regular wear traditions and modesty are to be observed. And Allah Knows Best