Is the patient who is on dialysis twice a week obliged to observe fasting? Is his fasting on the days he is on dialysis considered valid or not?

Praise be to Allah the Lord of the Worlds.

Dialysis invalidates fasting because of the nutritional fluid used in that procedure, as pointed by specialized doctors, in addition to causing bodies to enter the stomach. Therefore, it is recommended that the patient who had undergone dialysis to observe fasting for the rest of that day, if he is able to, and make up for it after Ramadan. However, if the doctor told him that fasting, at any time, would damage his health, then he must break his fast and pay a ransom against every missed day. We pray that Allah blesses this person with recovery. And Allah The Almighty Knows Best.

Is it permissible for the man to go out wearing shorts?

All Perfect Praise is due to Allah, The Lord of The Worlds

It is permissible so long as his Awrah (private part), which is between his navel and knee, is covered. However, the regular wear traditions and modesty are to be observed. And Allah Knows Best

Are all the children of a suckling woman considered brothers to the strange child whom their mother had breastfed, or just to the one who had suckled with him?

All the children of the woman who had suckled a strange child are considered his/her brothers and sisters.

What is the ruling on performing voluntary prayers during official working hours?

All perfect praise be to Allah, The Lord of The Worlds, and may His Peace and Blessings be upon our Prophet Muhammad and upon all of his family and companions

There is no harm if  there was break time during official working hours, but if not then it is impermissible. And Allah Knows Best.