Should a person feel pleased, or have a virtuous vision after offering Istikhara (guidance prayer) in order to do what he/she had offered it for?
The result of the Istikhaarah is not necessarily that a person sees something (in his dream), or feels pleased, but the most important result of the Istikhaarah is whether a person is enabled to do a given matter or not.
Is it permissible for one to give the Zakah (obligatory charity) to his indebted brother?
It is permissible for one to give the Zakah to his brother if he was indebted, or poor.
A young man who works for a conventional bank has proposed to me. Is it forbidden to marry him because he works there?
All perfect praise be to Allah the Lord of the Worlds. May His peace and blessings be upon Prophet Mohammad and upon all his family and companions.
Since the Messenger of Allah (PBUH) said: "When someone with whose religion and character you are satisfied asks your daughter in marriage, accede to his request. If you do not do so there will be temptation in the earth and extensive corruption."
Marrying such a person is permissible because he is a Muslim, and Allah may bless him with another job in which no usury/interest is involved. And Allah The Most Exalted Knows Best.
Is it permissible for a husband to stop his wife from visiting her family?
A husband shouldn`t stop his wife from visiting her family, and it is disliked for him to do so because such an act makes them harbor feelings of hatred against him.