A man who was on travel prayed Duhr as four Rakhas upon leaving Tafilah heading to Amman. However, on his way to Amman, he prayed Asir as two Rakhas (Shortened). Is what he did correct from an Islamic perspective?
All perfect praise be to Allah, The Lord of The Worlds. May His blessings and peace be upon our Prophet Mohammad and upon all his family and companions.
What he did is correct; he is liable for nothing before Allah The Almighty, since combining and shortening prayers during travel are two separate concessions. Therefore, it is permissible for a traveler to shorten prayer without combining it with another. And Allah The Almighty Knows Best.
Is it permissible for a woman to adorn herself with kohl (eyeliner) and go out wearing it?
Kohl is a form of adornment, and it is forbidden for a woman to display her adornment to anyone other than her husband or a Mahram. And Allah Knows Best.
Is permissible to buy/sell with non-Muslim?
Yes buying/selling for a Muslim with non-Muslim is permissible as regards what is lawful.
A pious man proposed to me and my father was hesitant in this regard because he is black, am I sinful if I accepted his proposal?
If the suitor is pious, color isn`t a drawback. However, try talking to your father kindly, so that he approves of your marriage with contentment, and that is better for you.