Is the one who gives up on marriage because he can`t afford it considered sinful?
Marriage is desirable, but one who can`t afford it isn`t considered sinful. However, he should supplicate to Allah, and seek His forgiveness.
Should a person feel pleased, or have a virtuous vision after offering Istikhara (guidance prayer) in order to do what he/she had offered it for?
The result of the Istikhaarah is not necessarily that a person sees something (in his dream), or feels pleased, but the most important result of the Istikhaarah is whether a person is enabled to do a given matter or not.
What is the ruling on having brotherly ties between a strange man and a strange woman, and is the former considered a Mahram (unmarriageable) to the latter?
Such a relation between a strange man and a strange woman is forbidden in Islam because it involves forbidding what Allah has allowed by marriage, and allowing what Allah has forbidden such as looking and the like. Such a relation doesn`t render any act lawful between them, thus they are forbidden to look at each other, have a Khulwah (seclusion), and travel together.
I joined a savings club and was scheduled to receive the payout first. My friend asked to take my place in line, so I requested 50 dinars in exchange for letting her have my turn. What is the ruling on this?
This is impermissible, as it involves taking money without providing something of value in return according to Islamic law. And Allah The Almighty Knows Best.