Is the one who gives up on marriage because he can`t afford it considered sinful?
Marriage is desirable, but one who can`t afford it isn`t considered sinful. However, he should supplicate to Allah, and seek His forgiveness.
Is it permissible for a woman to shake hands with her brother-in-law?
It is forbidden for the woman to shake hands with her brother-in-law because he isn`t a Mahram (unmarriageable) of hers.
Should a person feel pleased, or have a virtuous vision after offering Istikhara (guidance prayer) in order to do what he/she had offered it for?
The result of the Istikhaarah is not necessarily that a person sees something (in his dream), or feels pleased, but the most important result of the Istikhaarah is whether a person is enabled to do a given matter or not.
What is the Islamic ruling regarding a person finding buried treasure, whether gold or artifacts, and what is their share of it?
If the buried treasure is Islamic, it is considered Luqta (lost property), and the finder must announce it to locate its owner. If all efforts to find the owner fail, the finder may take ownership of it. If the treasure is non-Islamic and consists of gold or silver, zakat must be paid on it, which is one-fifth of its value. And Allah Knows Best.