What is the ruling on performing ablution (wudu') and ritual bathing (ghusl) with Zamzam water?
It is permissible to perform ablution and ritual bathing with Zamzam water. However, scholars disliked using it for cleaning after relieving oneself (istinja'). And Allah the Almighty knows best.
Is it permissible for the young woman to turn the suitor down if she had no feelings for him?
Yes, it is permissible for her to do so.
Is it permissible for a woman to sit with her brothers-in-law?
It is impermissible for a woman to sit with her brothers-in-law, and it is also impermissible for a person to have a Khulwa (seclusion) with his sister-in-law.
Should a person feel pleased, or have a virtuous vision after offering Istikhara (guidance prayer) in order to do what he/she had offered it for?
The result of the Istikhaarah is not necessarily that a person sees something (in his dream), or feels pleased, but the most important result of the Istikhaarah is whether a person is enabled to do a given matter or not.
