Should a person feel pleased, or have a virtuous vision after offering Istikhara (guidance prayer) in order to do what he/she had offered it for?
The result of the Istikhaarah is not necessarily that a person sees something (in his dream), or feels pleased, but the most important result of the Istikhaarah is whether a person is enabled to do a given matter or not.
Is it permissible for a woman to shake hands with her brother-in-law?
It is forbidden for the woman to shake hands with her brother-in-law because he isn`t a Mahram (unmarriageable) of hers.
Is the son of the sister by breastfeeding considered a mahram in Islam, and is it permissible for a woman to go for Hajj with him?
Everything that is prohibited by lineage is also prohibited by breastfeeding. The son of the sister by breastfeeding is considered a mahram, just like the son of the sister by blood, and it is permissible for him to be her mahram for Hajj and Umrah. And Allah Knows Best.
Is the one who gives up on marriage because he can`t afford it considered sinful?
Marriage is desirable, but one who can`t afford it isn`t considered sinful. However, he should supplicate to Allah, and seek His forgiveness.