What is the ruling on performing ablution (wudu') and ritual bathing (ghusl) with Zamzam water?
It is permissible to perform ablution and ritual bathing with Zamzam water. However, scholars disliked using it for cleaning after relieving oneself (istinja'). And Allah the Almighty knows best.
Should a person feel pleased, or have a virtuous vision after offering Istikhara (guidance prayer) in order to do what he/she had offered it for?
The result of the Istikhaarah is not necessarily that a person sees something (in his dream), or feels pleased, but the most important result of the Istikhaarah is whether a person is enabled to do a given matter or not.
Is the one who gives up on marriage because he can`t afford it considered sinful?
Marriage is desirable, but one who can`t afford it isn`t considered sinful. However, he should supplicate to Allah, and seek His forgiveness.
When is Istikharah (guidance prayer) Du`a offered, before Tasleem (saying asalamu alikum warahmatu allah wa barakatuh to end the prayer), or after it?
It is offered after Tasleem.