Is the one who gives up on marriage because he can`t afford it considered sinful?
Marriage is desirable, but one who can`t afford it isn`t considered sinful. However, he should supplicate to Allah, and seek His forgiveness.
Is the son of the sister by breastfeeding considered a mahram in Islam, and is it permissible for a woman to go for Hajj with him?
Everything that is prohibited by lineage is also prohibited by breastfeeding. The son of the sister by breastfeeding is considered a mahram, just like the son of the sister by blood, and it is permissible for him to be her mahram for Hajj and Umrah. And Allah Knows Best.
Is it permissible for a wife to boycott (not to attend to his different needs) her husband?
It isn`t permissible for the woman to boycott her husband unless he is the reason behind that, and it is recommended that both spouses seek the advice of righteous people to make reconciliation.
A pious man proposed to me and my father was hesitant in this regard because he is black, am I sinful if I accepted his proposal?
If the suitor is pious, color isn`t a drawback. However, try talking to your father kindly, so that he approves of your marriage with contentment, and that is better for you.