When is Istikharah (guidance prayer) Du`a offered, before Tasleem (saying asalamu alikum warahmatu allah wa barakatuh to end the prayer), or after it?
It is offered after Tasleem.
Is it permissible for a husband to stop his wife from visiting her family?
A husband shouldn`t stop his wife from visiting her family, and it is disliked for him to do so because such an act makes them harbor feelings of hatred against him.
Should a person feel pleased, or have a virtuous vision after offering Istikhara (guidance prayer) in order to do what he/she had offered it for?
The result of the Istikhaarah is not necessarily that a person sees something (in his dream), or feels pleased, but the most important result of the Istikhaarah is whether a person is enabled to do a given matter or not.
Is it valid to have Suhoor before sleeping, even if it is before midnight?
Suhoor refers to the pre-dawn meal eaten after midnight to help a Muslim endure fasting. The closer it is to Fajr, the better.
The Prophet ﷺ said: "My Ummah will remain upon goodness as long as they hasten to break the fast and delay Suhoor." [Narrated by Ahmad]
This is because delaying Suhoor makes it more effective in providing strength for worship. However, if there is a risk of Fajr entering while eating, one should refrain from Suhoor out of caution.
The Prophet ﷺ said: "Leave what makes you doubt for what does not make you doubt." [Narrated by Al-Tirmidhi]