What should a person, who doubts the validity of his Wudu, or over performs it, do?
One who doubts the validity of his/her Wudu while performing it should redo it until he/she is certain of having attained purity. But, if doubt was after having performed Wudu, then he/she should not pay attention to that as doubt after the end of an act of worship does not count. This is of course in case doubt was within the reasonable limits since once it goes beyond that, it becomes a whispering of the Shaytaan (devil) which he/she should ignore as the Wudu is valid.
Should a person feel pleased, or have a virtuous vision after offering Istikhara (guidance prayer) in order to do what he/she had offered it for?
The result of the Istikhaarah is not necessarily that a person sees something (in his dream), or feels pleased, but the most important result of the Istikhaarah is whether a person is enabled to do a given matter or not.
Is it obligatory to have an intention (niyyah) for every prayer?
Praise be to Allah, and peace and blessings be upon our Master, the Messenger of Allah.
It is obligatory for the worshiper to have a specific intention (Niyyah) for every prayer, meaning they must consciously intend the act of worship they are performing. The intention is a pillar (Rukn) of the prayer, and the prayer is not valid without it. It is not a requirement to utter the intention verbally; rather, doing so is considered a recommended Sunnah. And Allah the Exalted knows best.
How should I deal with the whispers of the devil with regard to ablution and purity?
Whispers in ablution are from the devil, and so you should take refuge in Allah from the devil`s evil suggestions that aim to distort the religion. Thus, once an organ is completely pure, don`t question its purity since having whispers doesn`t mean that the purity is invalid as it has already been established.