If the menses lasted for over than 9 to 10 days, considered menstruation?
If the duration of the bleeding does not exceed fifteen days, it is all considered menstruation, even if the usual pattern changes.
Is the son of the sister by breastfeeding considered a mahram in Islam, and is it permissible for a woman to go for Hajj with him?
Everything that is prohibited by lineage is also prohibited by breastfeeding. The son of the sister by breastfeeding is considered a mahram, just like the son of the sister by blood, and it is permissible for him to be her mahram for Hajj and Umrah. And Allah Knows Best.
Should a person feel pleased, or have a virtuous vision after offering Istikhara (guidance prayer) in order to do what he/she had offered it for?
The result of the Istikhaarah is not necessarily that a person sees something (in his dream), or feels pleased, but the most important result of the Istikhaarah is whether a person is enabled to do a given matter or not.
Should the Zakah (obligatory charity) giver tell the poor recipient that this is the Zakah of his money?
No, he shouldn`t. But, the Zakah giver should make an intention in his heart that it is the Zakah of his money when paying it to the poor. And Allah Knows Best.