What should one who doubts the validity of his ablution and performs it frequently do?
Whoever doubts the validity of his ablution after finishing it, his ablution is valid. This is because the default is the validity of the ablution, and because doubt after finishing an act of worship doesn`t affect its validity. And Allah the Almighty knows best.
What is the ruling on vomiting, and does it invalidate ablution?
Vomit is impure (najis). Its exit is not considered one of the nullifiers of ablution. However, the mouth must be washed and purified from it, and any that gets on clothing or the body must be washed for prayer, because prayer is not valid with impurity present on the body or clothing. And Allah the Almighty knows best.
What is the ruling on one who performs ablution or the ritual bath while having nail polish?
Nail polish must be removed before ablution or ritual bath so that water reaches what is beneath it, because it is a barrier that prevents water from reaching that area. This is based on the hadith narrated by Ali (may Allah be pleased with him) from the Prophet (peace be upon him): "Whoever leaves a hair's breadth of his body unwashed from major impurity, such and such will be done to him in the Fire." (Reported by al-Bukhari). And Allah the Almighty knows best.
Should a person feel pleased, or have a virtuous vision after offering Istikhara (guidance prayer) in order to do what he/she had offered it for?
The result of the Istikhaarah is not necessarily that a person sees something (in his dream), or feels pleased, but the most important result of the Istikhaarah is whether a person is enabled to do a given matter or not.