Is Zakah (obligatory charity) due on land intended for selling?
Yes, lands intended for trade are valued, and Zakah is paid according to their estimated value after a lunar year had lapsed, but if the owner didn`t pay the due Zakah, then he should do so after selling them.
What should the one performing the slaughter say at the time of slaughtering the 'aqīqah?
All praise is due to Allah, and may peace and blessings be upon our Master, the Messenger of Allah.
It is Sunnah to say the following supplication at the time of slaughtering the 'aqīqah:
"Bismillāhi wallāhu Akbar, Allāhumma laka wa ilayka, hādhihi 'aqīqatu fulān."
("In the name of Allah, and Allah is the Greatest. O Allah, this is for You and unto You — this is the 'aqīqah of [the child's name].")
This is based on what al-Bayhaqī narrated in Al-Sunan al-Kubrā (Vol.9/P.511), that the Prophet ﷺ said: "Slaughter it in his name and say: In the name of Allah, and Allah is the Greatest. O Allah, this is for You and unto You — this is the 'aqīqah of so-and-so."
And Allah Almighty knows best.
Should a person feel pleased, or have a virtuous vision after offering Istikhara (guidance prayer) in order to do what he/she had offered it for?
The result of the Istikhaarah is not necessarily that a person sees something (in his dream), or feels pleased, but the most important result of the Istikhaarah is whether a person is enabled to do a given matter or not.
Does smoking break the fast?
Yes, smoking breaks the fast because smoke particles intentionally enter the lungs, which are considered part of the body cavity (jauf).