I swear that I will leave the religion of Allah if I return to smoking" and then returned to smoking. What is the ruling?
Whoever conditions disbelief on something and intends to disbelieve if it happens, he becomes a disbeliever immediately. Therefore, you must pronounce the two testimonies of faith (Shahada) and reconcile with your wife if she is in her waiting period (Iddah). It is recommended to consult the Department of Fatwa for further guidance. And Allah Knows Best.
Is it permissible to offer Istikhara prayer (seeking guidance) after Witr Prayer (A confirmed Sunnah which is offered after Isha prayer and before Fajir prayer with a minimum of 3 Rak`as and a maximum of 11)?
It is permissible to offer Istikhara before and after Witr prayer as it is permissible at any time except that in which prayer is disliked. And Allah Knows Best.
Is it permissible to give Zakah (obligatory charity) to one`s poor sister, or brother?
It is permissible for one to give the Zakah to his poor sister, or brother if providing for them isn`t due on him, and the sister doesn`t receive sufficient provision from whomever that is due on. And Allah Knows Best.
Should a person feel pleased, or have a virtuous vision after offering Istikhara (guidance prayer) in order to do what he/she had offered it for?
The result of the Istikhaarah is not necessarily that a person sees something (in his dream), or feels pleased, but the most important result of the Istikhaarah is whether a person is enabled to do a given matter or not.