Should a person feel pleased, or have a virtuous vision after offering Istikhara (guidance prayer) in order to do what he/she had offered it for?
The result of the Istikhaarah is not necessarily that a person sees something (in his dream), or feels pleased, but the most important result of the Istikhaarah is whether a person is enabled to do a given matter or not.
Is Zakah (obligatory charity) due on the money saved for marriage?
Zakah is due on the money saved for marriage if it reached the Nissab (minimum amount liable for Zakah), and a whole lunar year had lapsed over possessing it.
Is it permissible for a person who is in a state of Janabah (Ritual impurity) to clip his nails, or to cut his hair?
It is permissible for those in a state of Janabah and menstruation to clip their nails and to shave whatever hair that is permissible to be shaved. And Allah Knows Best.
Is it permissible to swear by (Allah "The Living")?
Yes, it is permissible because "The Living" is one of Allah`s Attributes.