Should a person feel pleased, or have a virtuous vision after offering Istikhara (guidance prayer) in order to do what he/she had offered it for?
The result of the Istikhaarah is not necessarily that a person sees something (in his dream), or feels pleased, but the most important result of the Istikhaarah is whether a person is enabled to do a given matter or not.
What is the ruling on seeking forgiveness between the two Friday sermons?
Praise be to Allah, and peace and blessings be upon our Master, the Messenger of Allah.
It is permissible to seek forgiveness (Istighfar) between the two Friday sermons (Khutbatayn), and it does not invalidate the Friday prayer (Salat al-Jumu'ah). Furthermore, it is not disliked (Makruh) to speak before the sermon, after it, or between the two sermons. Likewise, it is not disliked for one who enters during the sermon to speak if there is a need for it, provided he has not yet taken a place and settled into it. And Allah the Exalted knows best.
Does smoking break the fast?
Yes, smoking breaks the fast because smoke particles intentionally enter the lungs, which are considered part of the body cavity (jauf).
How should I deal with the whispers of the devil with regard to ablution and purity?
Whispers in ablution are from the devil, and so you should take refuge in Allah from the devil`s evil suggestions that aim to distort the religion. Thus, once an organ is completely pure, don`t question its purity since having whispers doesn`t mean that the purity is invalid as it has already been established.