Should a person feel pleased, or have a virtuous vision after offering Istikhara (guidance prayer) in order to do what he/she had offered it for?
The result of the Istikhaarah is not necessarily that a person sees something (in his dream), or feels pleased, but the most important result of the Istikhaarah is whether a person is enabled to do a given matter or not.
Can I start fasting based on the moon sighting of another country?
You must follow the moon sighting of the country you are in.
Is it permissible for a woman to wear underwear while performing Umrah?
Yes, it is permissible for a woman to wear underwear while performing Umrah. This is because she should keep her regular clothes that cover all her body while being in a state of Ihram (ritual consecration) for Hajj, or Umrah. However, she should uncover her face and hands, but it is permissible for her to let her head-covering garment drape from her head down over her face when non-Mahram (i.e., marriageable) men pass by her. And Allah Knows Best.
How to perform the witr prayer in terms of connection (wasl) and separation (fasl)?
Praise be to Allah, and peace and blessings be upon our Master, the Messenger of Allah.
The Witr prayer has several forms that vary in terms of virtue:
The First Form: Separating every two units (rak‘ah) with a Tashahhud and a Taslim (salutation). This is superior to connecting the units, even if it is only a single rak‘ah. This is based on the Hadith of ‘Aishah (may Allah be pleased with her): 'The Messenger of Allah ﷺ used to pray eleven units between the end of the ‘Isha prayer and dawn, performing the Taslim after every two units and performing Witr with a single unit.' (Related by al-Bukhari & Muslim).
The Second Form: Connecting the units with only one final Tashahhud at the very end.
The Third Form: Connecting with two Tashahhuds—meaning reciting the Tashahhud before the final unit without performing the Taslim, then standing to complete the final unit. This form is considered the lowest in rank so that the Witr prayer remains distinct from the obligatory Maghrib prayer, as stated in the Hadith: 'Do not make the Witr resemble the Maghrib prayer.' (Narrated by Al-Daraqutni, who stated its narrators are trustworthy).
It is stated in Bushra al-Karim Sharh al-Muqaddimah al-Hadramiyyah: 'It is permissible to connect [the Witr] with one Tashahhud in the final unit—which is better—or with two Tashahhuds in the last two units, as both methods are established in Sahih Muslim from the actions of the Prophet ﷺ. In the connected method, more than two Tashahhuds are prohibited. Furthermore, separating (al-Fasl) is better than connecting (al-Wasl) if the number of units is the same, because the Hadiths supporting it are more numerous and it involves more devotional actions.' And Allah the Exalted knows best."