Should a person feel pleased, or have a virtuous vision after offering Istikhara (guidance prayer) in order to do what he/she had offered it for?
The result of the Istikhaarah is not necessarily that a person sees something (in his dream), or feels pleased, but the most important result of the Istikhaarah is whether a person is enabled to do a given matter or not.
Is it permissible for a young man and a young woman to enter into a covenant as a married couple without having a true seclusion (Khalwah) until their marriage contract is officially concluded?
The relation which isn`t based on a marriage contract is forbidden, and entering into a covenant as a married couple is unaccounted for and is from the evil suggestions of the devil.
Does smoking break the fast?
Yes, smoking breaks the fast because smoke particles intentionally enter the lungs, which are considered part of the body cavity (jauf).
Is it permissible for a woman to shake hands with her brother-in-law?
It is forbidden for the woman to shake hands with her brother-in-law because he isn`t a Mahram (unmarriageable) of hers.